Merged
Conversation
keblodev
force-pushed
the
rz-error-check-issue
branch
from
0246bbd to
164aea6
Compare
Collaborator
|
Good catch. |
Author
|
yes - sure :) |
keblodev
force-pushed
the
rz-error-check-issue
branch
3 times, most recently
from
77d4859 to
fbb53fa
Compare
Author
|
@dxg , done. Please take a look. |
Collaborator
|
I wish there were 48 hours in the day... sorry for the delay. |
Collaborator
|
Published as part of v2.1.23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because if there's no
'find module'inex.message,the-1value fromindexOfis equal totrueand you'll never know what hit you.Right now basically on any error thrown in this
try {} catch- you'll get"Connection protocol not supported", which is wrongPlease review.